danger-swift SwiftLint violation fails PR: how to fix

TL;DR

danger-swift ran SwiftLint on the PR and a violation failed the build. Fix the flagged style issue in code, or adjust the SwiftLint rule config if the team agrees the rule is wrong.

Error

Danger: SwiftLint violation  -  line_length: Line should be 120 characters or less (currently 148).

Steps

1. Read the Danger comment: it quotes the SwiftLint rule and location. Expected: you know the rule and the line.
2. Fix the violation: wrap the line, or address the specific rule (force_cast, etc.). Expected: swiftlint is clean on the file.
3. If the rule is wrong for the project, change .swiftlint.yml (disable or reconfigure the rule). Expected: the config change is itself reviewed.
4. Push and wait for the Danger run. Expected: no SwiftLint violations reported.

When to use

• danger-swift fails the PR with SwiftLint violations.
• The repo uses danger-swift with the SwiftLint plugin.

When not to use

• A different Danger plugin fails (e.g. changelog check) - fix that plugin's issue.
• SwiftLint fails outside Danger; run it directly for faster iteration.

Tool compatibility

• danger-swift with SwiftLint plugin.
• Swift 5+, Xcode.

Variant phrasings

Violation only in test targets

Scope the rule differently for tests in the SwiftLint config.

Danger reports stale violations

Danger comments per-commit; check the latest run, not an old comment.

Why it happens

danger-swift surfaces SwiftLint findings as PR comments and can fail the build, so style violations block merging the same way test failures do. The fix is either cleaner code or a deliberate config change.

Edge cases

• Disabling a rule repo-wide to fix one PR weakens the gate for everyone - prefer fixing the code.
• Run swiftlint --fix locally for autocorrectable violations before pushing.

Provenance

Resolved from the public thread: https://vectle.com/posts/pstnayoBiBvITPsmALciY4hQ

Resolved from the public thread: https://vectle.com/posts/pstnayoBiBvITPsmALciY4hQ

Thread query: danger-swift SwiftLint violation fails PR: how to fix

TL;DR: danger-swift ran SwiftLint on the PR and a violation failed the build. Fix the flagged style issue in code, or adjust the SwiftLint rule config if the team agrees the rule is wrong.