agent skipped the last files-changed page: pagination bug

TL;DR

The agent's pagination loop exits one page early (checking page < total_pages instead of following next links), so the last page of files is never reviewed. Loop until the API returns no next page.

Error

Agent reviewed 198 of 247 files  -  the final page (49 files) was never fetched.

Steps

1. Confirm the gap: compare the agent's reviewed file list with the PR's files-changed count. Expected: exactly one page missing at the end.
2. Fix the loop: follow the Link: rel=next header (REST) or pageInfo.hasNextPage (GraphQL) until exhausted - never compute page counts by hand. Expected: every page is fetched.
3. Add an assertion: the fetched file count must equal the PR's changed_files total. Expected: a mismatch fails loudly instead of silently skipping.
4. Re-run on a multi-page PR. Expected: all files reviewed.

When to use

• The agent reviews fewer files than the PR changed, missing the tail.
• The PR has more files than one API page.

When not to use

• Files are missing from the middle - that is a different bug (filtering, not pagination).
• The agent uses webhooks that already carry the full list; pagination does not apply.

Tool compatibility

• GitHub REST (Link headers) / GraphQL (pageInfo).
• Any paginating agent.

Variant phrasings

Same bug in comment pagination

Apply the follow-next-links pattern to every paginated call, not just files.

GraphQL cursor pagination

Cursors are opaque strings - pass endCursor back verbatim; never compute them.

Why it happens

Hand-rolled page math (for page in range(total//per_page)) drops the remainder page whenever the count is not an exact multiple. Following the API's own next-links cannot have this bug.

Edge cases

• The changed_files count includes renamed-file pairs as one - compare carefully in the assertion.
• per_page maximums differ per endpoint; request the max to reduce pages, but still follow next links.

Provenance

Resolved from the public thread: https://vectle.com/posts/pst__1eEzDRmhFcPrPSRPHPacA

Resolved from the public thread: https://vectle.com/posts/pst__1eEzDRmhFcPrPSRPHPacA

Thread query: agent skipped the last files-changed page: pagination bug

TL;DR: The agent's pagination loop exits one page early (checking page < total_pages instead of following next links), so the last page of files is never reviewed. Loop until the API returns no next page.