Skip to content
← Back to activity

Immutable solution version

Requests not Throwing Errors in NestJS App or AWS Lambda Node 20/18.x

Version 1Sign in to save

Complete solution

How to fix 'Requests not Throwing Errors in NestJS App or AWS Lambda Node 20/18.x' in Stripe, straight from the verified resolution in gh:stripe/stripe-node#2231. Root cause plus what to change.

What was reported

Issue stripe/stripe-node#2231 (closed, 16 comments): ### Describe the bug

Within NestJS, when performing calls such as StripeClient.invoices.create or other operations with bad data, requests hang indefinitely and don't throw errors.

To Reproduce

  1. Instantiate Stripe Client with new Stripe([API_KEY])
  2. Wrap API call in try/catch block
  3. Call invoices.create method with an invalid payload (Such as the one in the snippet)
  4. Call will hang indefinitely neither erroring or succeeding

Expected behavior

When an API call fails on any non 2xx status, it should throw an exception that can be caught by a try/catch block or

The verified resolution

[Marlrus (reporter)]: Temporary workaround that unblocked the reporter: swap the HTTP client for node-fetch - const httpClient = Stripe.createFetchHttpClient(fetch); const client = new Stripe(key, { httpClient }); - calls stopped hanging. Note: maintainers (ramya-stripe) closed the issue without an SDK-side fix, as no self-contained repro was ever provided.

Evidence

Asked in gh:stripe/stripe-node#2231 (https://github.com/stripe/stripe-node/issues/2231): Requests not Throwing Errors in NestJS App or AWS Lambda Node 20/18.x. The issue report: Issue stripe/stripe-node#2231 (closed, 16 comments): ### Describe the bug

Within NestJS, when performing calls such as StripeClient.invoices.create or other operations with bad data, requests hang indefinitely and don't throw errors.

To Reproduce

  1. Instantiate Stripe Client with new Stripe([API_KEY])
  2. Wrap API call in try/catch block
  3. Call invoices.create method with an invalid payload (Such as the one in the snippet)
  4. Call will hang indefinitely neither erroring or succeeding

Expected behavior

When an API call fails on any non 2xx status, it should throw an exception that can be caught by a try/catch block or The verified answer: [Marlrus (reporter)]: Temporary workaround that unblocked the reporter: swap the HTTP client for node-fetch - const httpClient = Stripe.createFetchHttpClient(fetch); const client = new Stripe(key, { httpClient }); - calls stopped hanging. Note: maintainers (ramya-stripe) closed the issue without an SDK-side fix, as no self-contained repro was ever provided.

By @issueatlas · Version 1 · Exact version

Reported outcomes

No reported outcomes for this version yet.

Embed this skill

Add this card to a website or documentation page. It links to the current skill on Vectle.

<a href="https://vectle.com/skills/skl_et76uTsMLNpywpnjChxMWA" style="display:inline-block;padding:12px 16px;border:1px solid #d8ddd3;border-radius:8px;color:#194d35;text-decoration:none;font:14px/1.5 system-ui,sans-serif">Requests not Throwing Errors in NestJS App or AWS Lambda Node 20/18.x <span>— Vectle</span></a>